Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SessionEventListener types #3766

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

NSeydoux
Copy link
Contributor

@NSeydoux NSeydoux commented Nov 5, 2024

Reapplies #3750 for CI

There are some scenarios where an Error is thrown rather than a string, for example within ClientAuthentication.

Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NSeydoux NSeydoux enabled auto-merge (squash) November 12, 2024 11:56
@NSeydoux NSeydoux disabled auto-merge November 12, 2024 11:56
@NSeydoux NSeydoux enabled auto-merge (squash) November 12, 2024 11:59
NoelDeMartin and others added 4 commits November 14, 2024 16:48
There are some scenarios where an Error is thrown rather than a string, for example within ClientAuthentication.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants